Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ChipDeviceCtrl: Fix type & doc for WriteAttribute #30824

Merged
merged 1 commit into from
Dec 5, 2023
Merged

ChipDeviceCtrl: Fix type & doc for WriteAttribute #30824

merged 1 commit into from
Dec 5, 2023

Conversation

cecille
Copy link
Contributor

@cecille cecille commented Dec 5, 2023

I went one layer too low when I wrote the documentation for the return type. Also, the type hint for attributes is wrong - I think this was copied from events, which include urgency. But write does not have or need that. Documentation and normal usage match the new type hint.

@cecille
ChipDeviceCtrl: Fix type & doc for WriteAttribute
677c1af 
I went one layer too low when I wrote the documentation for the
return type. Also, the type hint for attributes is wrong - I think
this was copied from events, which include urgency. But write does
not have or need that. Documentation and normal useage match the
new type hint.
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2023 •
edited
Loading

PR #30824: Size comparison from 5bd7c37 to 677c1af

Decreases (1 build for efr32)
platform target config section 5bd7c37 677c1af change % change
efr32 lighting-app BRD4187C (read/write) 1100188 1100180 -8 -0.0
.text 900700 900692 -8 -0.0
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 5bd7c37 677c1af change % change
bl602 lighting-app bl602 (read/write) 1412774 1412774 0 0.0
.bss 85160 85160 0 0.0
.data 9416 9416 0 0.0
.rodata 156868 156868 0 0.0
.text 1080682 1080682 0 0.0
bl602+mfd (read/write) 1427238 1427238 0 0.0
.bss 85328 85328 0 0.0
.data 9384 9384 0 0.0
.rodata 155828 155828 0 0.0
.text 1096046 1096046 0 0.0
bl602+rpc (read/write) 1460550 1460550 0 0.0
.bss 93192 93192 0 0.0
.data 9784 9784 0 0.0
.rodata 164484 164484 0 0.0
.text 1112426 1112426 0 0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1177447 1177447 0 0.0
.bss 11197 11197 0 0.0
.data 3584 3584 0 0.0
.rodata 106240 106240 0 0.0
.text 950050 950050 0 0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1188323 1188323 0 0.0
.bss 11373 11373 0 0.0
.data 3568 3568 0 0.0
.rodata 105180 105180 0 0.0
.text 961858 961858 0 0.0
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1269203 1269203 0 0.0
.bss 19677 19677 0 0.0
.data 4144 4144 0 0.0
.rodata 121660 121660 0 0.0
.text 1024856 1024856 0 0.0
bl706-eth (read/write) 997409 997409 0 0.0
.bss 23772 23772 0 0.0
.data 3160 3160 0 0.0
.rodata 99572 99572 0 0.0
.text 743282 743282 0 0.0
bl706-wifi (read/write) 1233702 1233702 0 0.0
.bss 10641 10641 0 0.0
.data 3600 3600 0 0.0
.rodata 120552 120552 0 0.0
.text 968734 968734 0 0.0
bl702l lighting-app bl702l (read only) 512 512 0 0.0
(read/write) 1147152 1147152 0 0.0
.bss 16392 16392 0 0.0
.data 4952 4952 0 0.0
.rodata 100244 100244 0 0.0
.text 943176 943176 0 0.0
bl702l+mfd (read only) 512 512 0 0.0
(read/write) 1158348 1158348 0 0.0
.bss 16568 16568 0 0.0
.data 4928 4928 0 0.0
.rodata 99184 99184 0 0.0
.text 955296 955296 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 742164 742164 0 0.0
(read/write) 167116 167116 0 0.0
.bss 89532 89532 0 0.0
.data 3420 3420 0 0.0
.rodata 84640 84640 0 0.0
.text 657136 657136 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 759308 759308 0 0.0
(read/write) 177344 177344 0 0.0
.bss 99708 99708 0 0.0
.data 3448 3448 0 0.0
.rodata 79704 79704 0 0.0
.text 679216 679216 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 746292 746292 0 0.0
(read/write) 171800 171800 0 0.0
.bss 94164 94164 0 0.0
.data 3448 3448 0 0.0
.rodata 105488 105488 0 0.0
.text 640412 640412 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 699812 699812 0 0.0
(read/write) 166120 166120 0 0.0
.bss 88312 88312 0 0.0
.data 3408 3408 0 0.0
.rodata 80416 80416 0 0.0
.text 619008 619008 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 685324 685324 0 0.0
(read/write) 166292 166292 0 0.0
.bss 88488 88488 0 0.0
.data 3404 3404 0 0.0
.rodata 76248 76248 0 0.0
.text 608688 608688 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 566362 566362 0 0.0
(read/write) 207620 207620 0 0.0
.bss 201084 201084 0 0.0
.data 1412 1412 0 0.0
.rodata 83890 83890 0 0.0
.text 480348 480348 0 0.0
lock CC3235SF_LAUNCHXL (read only) 619610 619610 0 0.0
(read/write) 208016 208016 0 0.0
.bss 201448 201448 0 0.0
.data 1448 1448 0 0.0
.rodata 105762 105762 0 0.0
.text 511728 511728 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 560559 560559 0 0.0
.app_xip_area 450849 450849 0 0.0
.bss 64624 64624 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 542607 542607 0 0.0
.app_xip_area 428161 428161 0 0.0
.bss 69320 69320 0 0.0
.data 700 700 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 561463 561463 0 0.0
.app_xip_area 453209 453209 0 0.0
.bss 63240 63240 0 0.0
.data 588 588 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 556671 556671 0 0.0
.app_xip_area 445193 445193 0 0.0
.bss 66360 66360 0 0.0
.data 696 696 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 1015548 1015548 0 0.0
.bss 172568 172568 0 0.0
.data 2688 2688 0 0.0
.text 840272 840272 0 0.0
BRD4187C (read/write) 1100188 1100180 -8 -0.0
.bss 196172 196172 0 0.0
.data 3296 3296 0 0.0
.text 900700 900692 -8 -0.0
lock-app BRD4161A+wf200 (read/write) 1113344 1113344 0 0.0
.bss 188624 188624 0 0.0
.data 2712 2712 0 0.0
.text 921988 921988 0 0.0
window-app BRD4187C (read/write) 1134152 1134152 0 0.0
.bss 168204 168204 0 0.0
.data 3168 3168 0 0.0
.text 962760 962760 0 0.0
esp32 all-clusters-app c3devkit (read only) 1135560 1135560 0 0.0
(read/write) 1670532 1670532 0 0.0
.dram0.bss 72536 72536 0 0.0
.dram0.data 12988 12988 0 0.0
.flash.rodata 241136 241136 0 0.0
.flash.text 1135560 1135560 0 0.0
.iram0.text 75694 75694 0 0.0
m5stack (read only) 1180707 1180707 0 0.0
(read/write) 519720 519720 0 0.0
.dram0.bss 79192 79192 0 0.0
.dram0.data 34004 34004 0 0.0
.flash.rodata 272160 272160 0 0.0
.flash.text 1175323 1175323 0 0.0
.iram0.text 123907 123907 0 0.0
k32w contact k32w0+release (read only) 594288 594288 0 0.0
(read/write) 88128 88128 0 0.0
.bss 71376 71376 0 0.0
.data 2128 2128 0 0.0
.text 593752 593752 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 689936 689936 0 0.0
.bss 67584 67584 0 0.0
.data 2716 2716 0 0.0
.text 576160 576160 0 0.0
light k32w0+release (read only) 594008 594008 0 0.0
(read/write) 87804 87804 0 0.0
.bss 71064 71064 0 0.0
.data 2116 2116 0 0.0
.text 593472 593472 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 781756 781756 0 0.0
.bss 77252 77252 0 0.0
.data 1928 1928 0 0.0
.text 659120 659120 0 0.0
lock k32w0+release (read only) 565792 565792 0 0.0
(read/write) 85600 85600 0 0.0
.bss 68920 68920 0 0.0
.data 2056 2056 0 0.0
.text 565256 565256 0 0.0
linux air-purifier-app debug (read only) 2523725 2523725 0 0.0
(read/write) 127176 127176 0 0.0
.bss 46944 46944 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 72760 72760 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 179240 179240 0 0.0
.text 2169221 2169221 0 0.0
all-clusters-app debug (read only) 5356473 5356473 0 0.0
(read/write) 443616 443616 0 0.0
.bss 130064 130064 0 0.0
.data 3840 3840 0 0.0
.data.rel.ro 302496 302496 0 0.0
.dynamic 624 624 0 0.0
.got 5352 5352 0 0.0
.init 27 27 0 0.0
.init_array 1224 1224 0 0.0
.rodata 306844 306844 0 0.0
.text 4649603 4649603 0 0.0
all-clusters-minimal-app debug (read only) 4945969 4945969 0 0.0
(read/write) 234624 234624 0 0.0
.bss 127856 127856 0 0.0
.data 3776 3776 0 0.0
.data.rel.ro 95872 95872 0 0.0
.dynamic 624 624 0 0.0
.got 5312 5312 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 272781 272781 0 0.0
.text 4440883 4440883 0 0.0
bridge-app debug (read only) 4413521 4413521 0 0.0
(read/write) 215864 215864 0 0.0
.bss 119224 119224 0 0.0
.data 4704 4704 0 0.0
.data.rel.ro 85200 85200 0 0.0
.dynamic 624 624 0 0.0
.got 5280 5280 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 219125 219125 0 0.0
.text 3975939 3975939 0 0.0
chip-tool debug (read only) 11165705 11165705 0 0.0
(read/write) 486280 486280 0 0.0
.bss 94072 94072 0 0.0
.data 4994 4994 0 0.0
.data.rel.ro 379976 379976 0 0.0
.dynamic 624 624 0 0.0
.got 5784 5784 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 412009 412009 0 0.0
.text 10095347 10095347 0 0.0
chip-tool-ipv6only arm64 (read only) 10945112 10945112 0 0.0
(read/write) 554008 554008 0 0.0
.bss 103352 103352 0 0.0
.data 4280 4280 0 0.0
.data.rel.ro 418528 418528 0 0.0
.dynamic 512 512 0 0.0
.got 19408 19408 0 0.0
.init 24 24 0 0.0
.init_array 248 248 0 0.0
.rodata 335632 335632 0 0.0
.text 9774600 9774600 0 0.0
lighting-app debug+rpc+ui (read only) 5299529 5299529 0 0.0
(read/write) 224936 224936 0 0.0
.bss 119360 119360 0 0.0
.data 4416 4416 0 0.0
.data.rel.ro 93616 93616 0 0.0
.dynamic 672 672 0 0.0
.got 5896 5896 0 0.0
.init 27 27 0 0.0
.init_array 960 960 0 0.0
.rodata 340212 340212 0 0.0
.text 4714643 4714643 0 0.0
lock-app debug (read only) 4499153 4499153 0 0.0
(read/write) 203584 203584 0 0.0
.bss 113760 113760 0 0.0
.data 3648 3648 0 0.0
.data.rel.ro 79432 79432 0 0.0
.dynamic 624 624 0 0.0
.got 5232 5232 0 0.0
.init 27 27 0 0.0
.init_array 856 856 0 0.0
.rodata 247029 247029 0 0.0
.text 4042227 4042227 0 0.0
ota-provider-app debug (read only) 4162825 4162825 0 0.0
(read/write) 192664 192664 0 0.0
.bss 113632 113632 0 0.0
.data 3904 3904 0 0.0
.data.rel.ro 69216 69216 0 0.0
.dynamic 624 624 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 201301 201301 0 0.0
.text 3769763 3769763 0 0.0
ota-requestor-app debug (read only) 4249225 4249225 0 0.0
(read/write) 196912 196912 0 0.0
.bss 114656 114656 0 0.0
.data 4176 4176 0 0.0
.data.rel.ro 72176 72176 0 0.0
.dynamic 624 624 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 205109 205109 0 0.0
.text 3848051 3848051 0 0.0
shell debug (read only) 2775929 2775929 0 0.0
(read/write) 149760 149760 0 0.0
.bss 60616 60616 0 0.0
.data 768 768 0 0.0
.data.rel.ro 82584 82584 0 0.0
.dynamic 592 592 0 0.0
.got 4104 4104 0 0.0
.init 27 27 0 0.0
.init_array 1072 1072 0 0.0
.rodata 180992 180992 0 0.0
.text 2424322 2424322 0 0.0
thermostat-no-ble arm64 (read only) 4400448 4400448 0 0.0
(read/write) 245968 245968 0 0.0
.bss 122232 122232 0 0.0
.data 2784 2784 0 0.0
.data.rel.ro 102288 102288 0 0.0
.dynamic 512 512 0 0.0
.got 12008 12008 0 0.0
.init 24 24 0 0.0
.init_array 424 424 0 0.0
.rodata 162332 162332 0 0.0
.text 3897848 3897848 0 0.0
tv-app debug (read only) 5360409 5360409 0 0.0
(read/write) 348480 348480 0 0.0
.bss 244192 244192 0 0.0
.data 4992 4992 0 0.0
.data.rel.ro 91976 91976 0 0.0
.dynamic 624 624 0 0.0
.got 5520 5520 0 0.0
.init 27 27 0 0.0
.init_array 1144 1144 0 0.0
.rodata 272341 272341 0 0.0
.text 4850931 4850931 0 0.0
tv-casting-app debug (read only) 9102881 9102881 0 0.0
(read/write) 329912 329912 0 0.0
.bss 156192 156192 0 0.0
.data 2464 2464 0 0.0
.data.rel.ro 164424 164424 0 0.0
.dynamic 624 624 0 0.0
.got 5064 5064 0 0.0
.init 27 27 0 0.0
.init_array 1136 1136 0 0.0
.rodata 355816 355816 0 0.0
.text 8304739 8304739 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2525400 2525400 0 0.0
.bss 220184 220184 0 0.0
.data 5144 5144 0 0.0
.text 1488084 1488084 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1060380 1060380 0 0.0
bss 129029 129029 0 0.0
rodata 104156 104156 0 0.0
text 779524 779524 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1186900 1186900 0 0.0
bss 121239 121239 0 0.0
rodata 138280 138280 0 0.0
text 777064 777064 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1045956 1045956 0 0.0
bss 129316 129316 0 0.0
rodata 99412 99412 0 0.0
text 769572 769572 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 836224 836224 0 0.0
(read/write) 1740740 1740740 0 0.0
.bss 194644 194644 0 0.0
.data 2472 2472 0 0.0
.text 1535236 1535236 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 837944 837944 0 0.0
(read/write) 1705044 1705044 0 0.0
.bss 192924 192924 0 0.0
.data 2472 2472 0 0.0
.text 1501260 1501260 0 0.0
light cy8ckit_062s2_43012 (read only) 844632 844632 0 0.0
(read/write) 1630164 1630164 0 0.0
.bss 186348 186348 0 0.0
.data 2360 2360 0 0.0
.text 1433068 1433068 0 0.0
lock cy8ckit_062s2_43012 (read only) 817512 817512 0 0.0
(read/write) 1657044 1657044 0 0.0
.bss 213444 213444 0 0.0
.data 2384 2384 0 0.0
.text 1432828 1432828 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1115876 1115876 0 0.0
.bss 101200 101200 0 0.0
.data 740 740 0 0.0
.text 628252 628252 0 0.0
lock-app qpg6105+debug (read/write) 1079516 1079516 0 0.0
.bss 97336 97336 0 0.0
.data 784 784 0 0.0
.text 591896 591896 0 0.0
telink air-quality-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 819858 819858 0 0.0
bss 54904 54904 0 0.0
text 612568 612568 0 0.0
all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1077376 1077376 0 0.0
bss 100072 100072 0 0.0
text 760116 760116 0 0.0
all-clusters-minimal-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 1082620 1082620 0 0.0
bss 109764 109764 0 0.0
text 752126 752126 0 0.0
bridge-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 933696 933696 0 0.0
bss 94272 94272 0 0.0
text 645980 645980 0 0.0
contact-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 820034 820034 0 0.0
bss 54948 54948 0 0.0
text 612862 612862 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 4 4 0 0.0
(read/write) 976632 976632 0 0.0
bss 78932 78932 0 0.0
text 692476 692476 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1091672 1091672 0 0.0
bss 99836 99836 0 0.0
text 768514 768514 0 0.0
lock-app-dfu tlsr9528a (read only) 4 4 0 0.0
(read/write) 963340 963340 0 0.0
bss 97196 97196 0 0.0
text 646600 646600 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 946984 946984 0 0.0
bss 92380 92380 0 0.0
text 661720 661720 0 0.0
pump-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 878772 878772 0 0.0
bss 68924 68924 0 0.0
text 620822 620822 0 0.0
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 819376 819376 0 0.0
bss 57160 57160 0 0.0
text 587698 587698 0 0.0
shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 705416 705416 0 0.0
bss 73588 73588 0 0.0
text 461916 461916 0 0.0
smoke_co_alarm-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 821694 821694 0 0.0
bss 55084 55084 0 0.0
text 615534 615534 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 876161 876161 0 0.0
bss 60636 60636 0 0.0
text 629126 629126 0 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 843588 843588 0 0.0
bss 57456 57456 0 0.0
text 606024 606024 0 0.0
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 838080 838080 0 0.0
bss 57808 57808 0 0.0
text 600240 600240 0 0.0

@mergify mergify bot merged commit 8677d1a into project-chip:master Dec 5, 2023
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@andy31415 andy31415 Awaiting requested review from andy31415

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@woody-apple woody-apple Awaiting requested review from woody-apple

Assignees
No one assigned
Labels
controller review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cecille @andy31415 @woody-apple